search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
610 stars 45 forks source link

Wrong parsing of "ローマじゃない" #49

Closed nicolasmaia closed 4 years ago

nicolasmaia commented 6 years ago

When parsing ローマじゃないです, Rikaichamp thinks it's looking at ローマ字. This problem can maybe be fixed if you tell the program to never separate じ from ゃ (and other similar cases).

birtles commented 6 years ago

That's a good idea!

nicolasmaia commented 6 years ago

This seems fixed from my end. Did you tweak with it?

birtles commented 6 years ago

Oh, no I don't know what happened there. I mean, I half rewrote the de-inflection code so that probably fixed it but actually I didn't expect the behavior to change so I'm afraid I might have broken other things in the process.

birtles commented 6 years ago

git bisect says this was fixed by fa1c7f77f826c0342d7aa82da3a230050f67ad2c but I have no idea why.

birtles commented 5 years ago

I'm closing this for now, but I really don't know exactly what fixed it.

neneko commented 4 years ago

This seems to be broken again.

birtles commented 4 years ago

Should be fixed in the next version.