search

birchill / 10ten-ja-reader

A browser extension to translate Japanese by hovering over words.
https://addons.mozilla.org/firefox/addon/10ten-ja-reader/
GNU General Public License v3.0
608 stars 45 forks source link

Pop-up box overlapping the mouse cursor and kanjis it shows on epub reader #803

Closed Rezel666 closed 3 years ago

Rezel666 commented 3 years ago

Using version 1.4.7 on Firefox with custom web/desktop readers. The extension itself working just fine, but box overlapping the word and cursor in reader is very annoying.

Both web and desktop readers are bib/i https://bibi.epub.link/

The cursor and source word right above the box on screenshot below.

изображение

birtles commented 3 years ago

Hi!

Thank you for filing this. Could you please explain how to reproduce this problem? For example, it there an example book I should open?

On the home page I can see one demo with Japanese text and the popup does seem to be out of place, but not in the way shown in the screenshot here (and when I open that demo full-screen, the popup seems to be in roughly the right place).

Rezel666 commented 3 years ago

https://drive.google.com/drive/folders/16d4nGyuu29aKWUXo20f7rHwHEH823BQt?usp=sharing

You can chech this folder. I dropped epub and the reader I use personally (desktop version). Problem persist through various epubs (checked at least 5 different titles' epubs with same result).

Prior to some update it was just fine. Can't say for sure what exact version caused this behaivour, since I barely touched epubs in last half a year due to workload.

birtles commented 3 years ago

Thanks. I'm not sure what's going on there but it's almost certainly related to the fact that that page is using iframes.

For a moment the popup seemed to be a bit far from the cursor for me, but now it seems right again:

image

I can see it's definitely broken if I zoom in. Do you know if you are zooming in or not? Or are the specific steps that make it get out of alignment?

Rezel666 commented 3 years ago

The version I use now and dropped into folder forcing horizontal text orientation (for convenience). No zoom involved at all.

Thechnically we have stock reader hosted online but there's no change in how 10ten works between those version.

изображение

There's similar extention but for chinese language (Papera Chinese), it works just fine if it could help to determine the source of said behaivour.

изображение

I just go to index page, drop epub, do nothing after, scroll to the text parts and trying to hover over kanjis. The result you can see above.

birtles commented 3 years ago

Great, thanks!

With the forced horizontal version of the reader I can reproduce it. I'll have a dig into it tomorrow.

Rezel666 commented 3 years ago

Thanks!

birtles commented 3 years ago

This should be fixed in 1.4.8 which shipped yesterday.

RawToast commented 2 years ago

@birtles Hey I came across Bibi after finding tutu reader slow it’s large epubs. I can get 10 to display the circle and it seems very responsive compared to in TTU, but I get no definitions. This is on the latest version & iOS.

This is reproducible on their demo book. https://imadokishimane.bex.jp/ebook/?book=imadoki_0302

As a note, the app works on iOS and MacOS for say NHK news; but I can't get any definitions in Safari on either my MacBook, iPad mini, or iPhone. They should all be on the latest versions of iOS/MacOS.