Popup cannot be pinned when the tabs are disabled

[Tomalak]

...since the push-pin button is on the tab bar. :)

Affects 1.12.0 and 1.12.2.

[birtles]

Does the keyboard shortcut still work? (Ctrl by default, unless you're using Alt as the key to show the popup)

There's no visual indication that it works in no tab mode, however so we should fix that. We could either:

1. Show the pin icon when pinned only (i.e. keep "no tab" mode minimal by default)
2. Show the pin icon alongside the "close" button.

Once the popup is pinned, we could even show the full tab bar since the user has indicated they want to interact with it.

(As a side note, for any users who have opted for "no tab" mode because they tab bar is too big on touchscreen devices, you can now disable mouse interaction and we'll use the thin tab bar, even on touchscreen devices, until you press Ctrl to pin the popup -- then the tab bar will enlarge.)

[Tomalak]

This is more of a usability inconsistency, but I'd expect the "mouse-interactable pin button" and the "tab bar" features to be orthogonal, since they are independently configurable in the settings.

Pinning the dialog with CTRL works fine when the tab bar is disabled, and is indicated by the border color. But it's quite obscure/non-discoverable from a UX perspective.

I'd prefer the pin button to show up next to the close button, that would be consistent.

[birtles]

I agree, we should probably show the pin icon in all states.

Unfortunately, the layout is a little bit tricky. I'll have to have a think about how to get it to wrap without creating an even wider gutter on the right (and without increasing the number of permutations of container elements we use).