search

birchroad / node-jspack

JavaScript library to pack primitives to octet arrays, packaged for NodeJS
http://code.google.com/p/jspack/
BSD 3-Clause "New" or "Revised" License
15 stars 12 forks source link

Adding 64bit int support #4

Closed AndreasAntener closed 9 years ago

AndreasAntener commented 10 years ago

Hi This adds support for longs (q and Q).

I came across jspack while working with the JS implementation of MAVLink, a UAV/drone communication library (https://github.com/mavlink/mavlink). MAVLink uses 64bit integers for timestamps (and for other stuff), so in order to use those I needed this. I added unit tests and Travis-CI support. You probably want to integrate your repository with Travis as well and change the link for the build status: https://github.com/AndreasAntener/node-jspack/compare/birchroad:master...master#diff-04c6e90faac2675aa89e2176d2eec7d8R4

Also it's "field" tested. I'm using this to parse and pack all my UAV telemetry links.

It would be great if you could update your NPM package with this.

Cheers Ada

kmpm commented 9 years ago

Sorry for beeing SOOOO late on this. I must have missed the notification.

AndreasAntener commented 9 years ago

Hi, cool! No worries. I completely forgot about that myself ;) But I'm happy to drop my submodule dependencies when this is in NPM

kmpm commented 9 years ago

Just published.