bird-house / birdhouse-deploy

Scripts and configurations to deploy the various birds and servers required for a full-fledged production platform
https://birdhouse-deploy.readthedocs.io/en/latest/
Apache License 2.0
4 stars 6 forks source link

:bulb: [Feature] Protect Portainer #335

Closed fmigneault closed 1 year ago

fmigneault commented 1 year ago

Description

Ensure Portainer is accessed behind Magpie/Twticher authentication/authorization. Currently, it uses its own authentication mechanism. It could be aligned with Magpie/Twitcher, or have a double-authentication layer. Either way, it should be limited to admin-only access.

References

tlvu commented 1 year ago

I think @mishaschwartz is dropping this one so can close this issue?

mishaschwartz commented 1 year ago

@tlvu Do you mean that we are deprecating portainer? Sorry if I missed that one. If so I need to remove it as part of #311.

tlvu commented 1 year ago

@mishaschwartz opps I vaguely remember you deprecated portainer with all the other (catalog, solr, frontend, ...)? Sorry if my memory is wrong. I have too much on my plate lately.

fmigneault commented 1 year ago

This was resolved in https://github.com/bird-house/birdhouse-deploy/pull/331 (not directly protected by Magpie/Twitcher, but port is not exposed anymore)

If we want to deprecate it, it can be another issue. Using a separate admin access is OK for now.