In several locations across the code-base, the PAVICS_FQDN environment variable is used to display URLs that are user-facing. These should almost exclusively use the PAVICS_FQDN_PUBLIC variable instead.
:warning:
If #428 has been merged already, then the relevant variables have been changed to BIRDHOUSE_FQDN and BIRDHOUSE_FQDN_PUBLIC
:warning:
Details
The following are examples that have been flagged, there may be others as well and a full review of the code-base is needed where PAVICS_FQDN is used
Summary
In several locations across the code-base, the PAVICS_FQDN environment variable is used to display URLs that are user-facing. These should almost exclusively use the PAVICS_FQDN_PUBLIC variable instead.
:warning: If #428 has been merged already, then the relevant variables have been changed to BIRDHOUSE_FQDN and BIRDHOUSE_FQDN_PUBLIC :warning:
Details
The following are examples that have been flagged, there may be others as well and a full review of the code-base is needed where
PAVICS_FQDNis usedhttps://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/components/magpie/magpie.ini.template#L31
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/components/thredds/config/proxy/conf.extra-service.d/thredds.conf.template#L4
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/components/twitcher/twitcher.ini.template#L54
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/components/twitcher/twitcher.ini.template#L68
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/env.local.example#L484-L485
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/env.local.example#L536
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/optional-components/README.rst?plain=1#L11
https://github.com/bird-house/birdhouse-deploy/blob/06e999752ee1b67a901299213e3a53b163b76c91/birdhouse/optional-components/test-geoserver-secured-access/config/proxy/conf.d/test-geoserver-secured.conf.template#L2
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/scripts/check-instance-ready#L22
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/scripts/check-instance-ready#L31
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/scripts/check-instance-ready#L44
https://github.com/bird-house/birdhouse-deploy/blob/8218166d5c8c7163293a656930ff85762eff4b60/birdhouse/scripts/create-magpie-users#L83
Environment
Concerned Organizations