search

bird-house / birdhouse-deploy

Scripts and configurations to deploy the various birds and servers required for a full-fledged production platform
https://birdhouse-deploy.readthedocs.io/en/latest/
Apache License 2.0
4 stars 6 forks source link

Jupyter env: new full build with latest of almost everything #453

Closed tlvu closed 6 months ago

tlvu commented 6 months ago

See https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/121 for more info.

birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false

tlvu commented 6 months ago

Looks good. Can we please also update the reference in the comment here:

https://github.com/bird-house/birdhouse-deploy/blob/a095db4688b5a415aac7969d6f4521981dcaec19/birdhouse/env.local.example#L266

That one is just an example. Once user copy env.local.example to env.local, they probably will never look back at env.local.example so I don't think there is value in keeping env.local.example up-to-date.

As time goes by, the example value in their env.local will become outdated anyways and there is no way I can control their copy of env.local.

mishaschwartz commented 6 months ago

I don't think there is value in keeping env.local.example up-to-date

New deployments will definitely use env.local.example as a reference to define which settings they will enable. If we're going to let it get out of date then it's not a good example at all. I think it is critical for new deployments that the env.local.example be kept up to date.

tlvu commented 6 months ago

I think it is critical for new deployments that the env.local.example be kept up to date.

Sure, I am happy to comply, this is a simple change.

I also added "See components/jupyterhub/default.env for the most updated version of pavics/workflow-tests." so it is clear in their own copy of env.local that their value will eventually be not up-to-date anymore.