Scripts that read configuration settings and that exit early on error fail unexpectedly

[mishaschwartz]

Overview

• Scripts that call set -e before reading configuration settings were failing early because some lines are intentionally returning a non-zero value when setting variable defaults. This change modifies lines that may return a non-zero status but should not cause the script to exit early.
• Scripts that were exiting early prior to this change include:
  • birdhouse/deployment/fix-geoserver-data-dir-perm
  • birdhouse/deployment/fix-write-perm
  • birdhouse/deployment/trigger-deploy-notebook

Changes

Non-breaking changes

• bug fix

Breaking changes

Related Issue / Discussion

Additional Information

Links to other issues or sources.

CI Operations

birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false

[mishaschwartz]

@tlvu @fmigneault

I've added some explanatory comments and I've parameterized the tests so that tests can run with and without set -e.

I agree that we should move the decision about whether to always run read-configs.includ.sh with set -e to another PR/Issue.