search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Enabling skipped tests #199

Closed huard closed 7 years ago

huard commented 7 years ago

I went through the tests that were skipped and re-activated those that I could fix.

The sdm_gbiffetch test is too slow to run. Solution would be to enable BBox or limit.

nilshempelmann commented 7 years ago

enabling bbox is a very good idea also for other issues. sdm_gbiffetch can also be improved in performance by changing the species name. The current Fagus sylvatica has many records in the database which takes time to read out.

huard commented 7 years ago

Darn, you told me that before and I forgot. Will do shortly.

huard commented 7 years ago

Done, but there are problems in test_indices.py. One test is failing (I've not investigated) and there seems to be inconsistencies in the output prefix. So not ready to merge until someone gives it a check.

nilshempelmann commented 7 years ago
test_indice_percentile could adopted to test_indice_dailypercentile which is implemented.

On 14/09/2017 23:00, MacPingu wrote:

@cehbrecht requested changes on this pull request.

looks good :)

The |test_indice_percentile| fails because the function is not really implemented. We need to skip the test for now. I can open a ticket for it and add a |raise NotImplementedError| so that no-one will use it.

Do you want to add the test skip? I can merge after ...

What do you mean with "inconsistent output prefixes"? Some tests seem to write in the current dir ... we can fix that after the merge.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bird-house/flyingpigeon/pull/199#pullrequestreview-62780272, or mute the thread https://github.com/notifications/unsubscribe-auth/AIPUql7AqOw0Oft7AtoVVu2CduQMZGnaks5siT9vgaJpZM4PVKI-.

huard commented 7 years ago

Output file naming seems to be inconsistent based on the test results. Haven't instigated, maybe it's something else.

nilshempelmann commented 7 years ago

Here a job with sdm_gbiffetch using 'Quercus trojana' as species to be searched and bbox disabled. performing time on bovec 4:35 min. May be still too long. https://bovec.dkrz.de/monitor/details/b8dc4170-0e9a-437c-ba36-7dea71effc50/outputs https://bovec.dkrz.de/download/wpsoutputs/flyingpigeon/d7c4783c-99bd-11e7-aa8a-109836a7cf3a/tmpkiFT2v.png

cehbrecht commented 7 years ago

thanks :) merged now.