search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Ocgis regrid process #223

Closed huard closed 6 years ago

huard commented 6 years ago

New WPS using ocgis to regrid netcdf files.

Fixes #217

Output is a json file storing the path to the output. Should we also add the first netcdf file itself ?

nilshempelmann commented 6 years ago

one test file as extra output was done to display it in a WMS. Is that still necessary to do so with a json? Can the WMS read the netCDF files (all of them) directly from json?

nilshempelmann commented 6 years ago

@cehbrecht I can't test the PR here. Internet is too weak today ...

cehbrecht commented 6 years ago

@huard the build is still not working. The buildout fails due to importing the flyingpigeon version which results in a long chain of other imports. We could work around this ... but the import that is failing will remain:

 from ocgis import RequestDataset
 /home/pingu/.conda/envs/flyingpigeon/lib/libesmf_fullylinked.so: undefined symbol: ESMC_InterfaceIntSet

@huard @bekozi What would you propose to fix the import issue?

huard commented 6 years ago

I think I've forgotton to add esmf to environment (on top of esmpy). I guess I assumed it would pull the dependency automatically. Let me test it and get back to you.

cehbrecht commented 6 years ago

@huard It looks promising :) Tests still fail because there is now a new process which the wps_caps test does not know about. Please add esmf_regrid to https://github.com/bird-house/flyingpigeon/blob/630243829a47b7473b4a6afaa9dc2faee4e51332/flyingpigeon/tests/test_wps_caps.py#L10

Tests are in alphabetical order. You can check locally with make test.

We can ignore codacy complains ... it is not our fault.

huard commented 6 years ago

Argh... sorry about this. Should have run make test.

make test has a failure in test_R_imports.

cehbrecht commented 6 years ago

looks good :)