search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Generic interface for file and opendap links #231

Closed huard closed 6 years ago

huard commented 6 years ago

We'd probably want all processes to accept either links to netCDF files or opendap URLs.

Could this be done through some kind of complexinput subclass ?

cehbrecht commented 6 years ago

@huard it can be done and it is on my todo list: https://github.com/geopython/pywps/issues/152

The current workaround it to use an extra input parameter (string) for OpenDAP. But that is not nice. See an example in hummingbird: https://github.com/bird-house/hummingbird/blob/6d5ea96641abf49eae3a7a4d126425e5396ff283/hummingbird/processes/wps_cfchecker.py#L47

huard commented 6 years ago

For reference, here is what Blaise did: https://github.com/Ouranosinc/flyingpigeon/blob/a914a70818c724e6b2a2de11ba4133fcc2dc7271/flyingpigeon/utils.py#L1195 A solution with mimetypes will probably be cleaner.

tomLandry commented 6 years ago

Labelling a few issues as "pavics". We'll soon review our backlog and assign items. Thanks for your patience, friends!

cehbrecht commented 6 years ago

I will close this ... we have OpenDAP support now in PyWPS 4.2.