search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Modernized String Formatting and Exception Raising #258

Closed Zeitsperre closed 6 years ago

Zeitsperre commented 6 years ago

Hey everyone,

I wanted to perform a huge cleanup of the processes to make them more readable as well as handle a lot of issues that can become problems down the line (bare exceptions, identifying uncalled/unassigned variables and functions). This PR is a refactor that doesn' break the API but is a major cleanup/refactor of the code layout and some minor grammatical corrections. Feel free to add edits as required.

Best,

huard commented 6 years ago

You probably want to comment EO processes for the pavics branch, not the birdhouse master.

cehbrecht commented 6 years ago

@Zeitsperre @huard @nilshempelmann You want to clean up FP master to merge it to the pavics fork? I would suggest to reduce it to what is working and wanted. The FP development is save in the 1.2.x branch ... the work doesn't get lost.

nilshempelmann commented 6 years ago

I suggest to clean up FP and moving as many as possible to eggshell. Disable buggy processes. @Zeitsperre what are you focussing on?

Zeitsperre commented 6 years ago

@nilshempelmann @cehbrecht

I'm hoping to bring the Ouranosinc/master up to standard with changes made on BH/master and then merge the Ouranosinc/pavics branch into it (the hard part).

Mainly, I wanted to clean up the processes and make them more readable, raising exceptions as often as possible and finding broken processes (identified with TODO's). As @huard mentioned, there are still a lot of buggy processes that could be left alone here and disabled in our production (pavics) branch. Otherwise, like @cehbrecht mentions, I could just delete the ones that need a lot more work and we could copy them over to eggshell later.

In order to move things to eggshell, the algorithms that work well still need to be cleaned up/simplified more. I'm not sure how to proceed for that (what's worth/not worth migrating?).

huard commented 6 years ago

There seems to be a problem with the R GOMP package, but that's probably unrelated to this PR.