Ouranosinc/pavics to upstream/master

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events

http://flyingpigeon.readthedocs.io/en/latest/

Apache License 2.0

19 stars 15 forks source link

Ouranosinc/pavics to upstream/master #262

Closed Zeitsperre closed 5 years ago

Zeitsperre commented 5 years ago

Finally merged to upstream. All processes except SubsetProcess-based ones are disabled due to various errors in the libraries of processes and the long build times on my current machine that prevent me from being able to effectively test what works and what doesn't.

Issues I'm aware of:

OCGIS requires xarray but conda doesn't seem to build them properly.
EO and EO_COPERNICUS processes fail on build.
flyingpigeon/utils.py contains both the eggshell imports and the older boilerplate code. Unsure if the boilerplate has been built into existing eggshell utilities.

Let me know if this is a really bad merge and I'll try my hand at making a cleaner merge of Ouranosinc/FP/master + Ouranosinc/FP/pavics + upstream master.

cehbrecht commented 5 years ago

@Zeitsperre are these R modules "re-intergrated" from an older flyingpigeon or are they used by a process comming from Ouranos?

flyingpigeon/Rsrc/climod/

Could you reduce the process list and conda dependencies to a working version? There might not be much left working due to the heavy dependency conflicts.

Zeitsperre commented 5 years ago

This version is a pretty bare-bones deployment already. The only processes I've enabled are subset-based. I can try removing more dependencies but as it stands, this fork does build.

~In terms of the R libraries, I don't think anything uses them from what I've seen. @huard does anything come to mind?~

Actually, I believe they're only necessary for the bias correction process in flyingpigeon/processes/wps_kddm_bc.py. Important but we can disable it for now.

huard commented 5 years ago

Correct, the R stuff is for the bias correction. This is important for the pavics deployment. But does not need to be in FP right now.

nilshempelmann commented 5 years ago

R depending flyingpigeon_v1.0 processes moved to blackswan. with the exception of the Tree species distribution model (SDM) processes. SDM are disabled since v1.2.1 and currently no need to enable them again.

cehbrecht commented 5 years ago

@Zeitsperre @nilshempelmann @huard Though this PR is not working, shall we merge it on master and move it to a 1.3.x branch. We keep it to have the previous work available.

After that we could restart the flyingpigeon generated with the cookiecutter and move in step by step the functions we like to have in flyingpigeon.

@huard @nilshempelmann What will be the focus of the restarted flyingpigeon? Will it be the exploration bird? Shall we restart the PAVICS flyingpigeon as a new bird?