search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Fix 274 #285

Closed huard closed 5 years ago

huard commented 5 years ago

Clean-up of subsetting operations: bbox and polygon from WFS server.

I've created a base subsetter class to centralize common operations for subsetters. I've removed a lot of the tests which were fairly complex. We might want to revive them in the future.

The first output is returned as a netCDF object, as usual, but multiple outputs are stored in a metalink file instead of a tar file.

Note also that I removed cookie passing code, as I had no way of testing it.

tomLandry commented 5 years ago

This could get very handy for the analysis page of the Climate Data portal.

huard commented 5 years ago

There are now similar processes in a Finch branch using xarray. I think it would be worth comparing and benchmarking the two implementations.

huard commented 5 years ago

Should a mismatch raise an error or just be logged ?

nilshempelmann commented 5 years ago

If the date is not found in the files, ocgis is crashing with an error.

I had a validation and set the date to the earliest/lates one possible. But this is a modification of the submitted job and the user needs to be informed. Usecase depending it is better to rise an error and point out the propper setting for the job.

cehbrecht commented 5 years ago

@huard @nilshempelmann merged. Thanks :)