fix: Subsetter.parse_resource generator now using is_opendap_url

[huard]

Overview

This PR fixes #304

Changes:

• Added is_opendap_url function from Finch
• Fixed generator logic
• make_geoms now returns a dict keyed by feature id
• added test for subset_wfs_polygon

Related Issue / Discussion

Additional Information

Links to other issues or sources.

[cehbrecht]

@huard looks good to me. Feel free to merge.

I didn't know about the f-strings in python 3.x https://realpython.com/python-f-strings/#f-strings-a-new-and-improved-way-to-format-strings-in-python

Also there is a new exception pattern in python 3.x:

raise Exception(msg) from other_error

codacy is not aware hat we use python 3.x only code.

You could check the other codacy complains ... import netcdf4.

[huard]

f-strings really make string formatting cleaner.

I've removed 3.5 in the supported versions (xarray dropped support for it last month).