search

bird-house / flyingpigeon

WPS processes for climate model data, indices and extreme events
http://flyingpigeon.readthedocs.io/en/latest/
Apache License 2.0
19 stars 15 forks source link

Process definition with minOccurs=1 and defaultvalue contracdict themselves #342

Open fmigneault opened 2 years ago

fmigneault commented 2 years ago

I noticed in following description that this process provides a region input with both explicit min_occurs=1 and default="DEU".

https://github.com/bird-house/flyingpigeon/blob/9f12aa319c4f190715c22b6cdf6cacdd4290b234/flyingpigeon/processes/wps_subset_countries.py#L31-L33

This produces a process description where it is hard to understand what is the expected behaviour. If an input is always required, there should not be a default. Otherwise, min_occurs=0 should be provided and it would be expected that this default is used. Right now, default serves no purpose and is counter intuitive.