search

bird-house / pyramid-phoenix

Phoenix is a Pyramid web-application to make it easy to interact with WPS services
http://pyramid-phoenix.readthedocs.io/en/latest/
Apache License 2.0
7 stars 10 forks source link

Issue raising error when logging in #197

Open tommygod3 opened 5 years ago

tommygod3 commented 5 years ago

The exception caught by: https://github.com/bird-house/pyramid-phoenix/blob/5c5a4f73778c31abdee13ce004dd651b43f24247/phoenix/account/base.py#L171 doesn't always have a .message attribute. Using str(result.error) works will all exceptions.

tommygod3 commented 5 years ago

Error goes from:

1

where the true error is obscured, to:

2

where the true error can be seen.

tommygod3 commented 5 years ago

The error that can be seen in the second image seems to be a problem with the authomatic library by the way, not with Phoenix. https://github.com/authomatic/authomatic/issues/199

cehbrecht commented 5 years ago

Since authomatic is not so well maintained we might skip it and move to oauthlib only, maybe together with pyramid-oauthlib. We would have logins for CEDA/ESGF, github, google, ...

tommygod3 commented 5 years ago

Sounds like a good solution to me.

cehbrecht commented 5 years ago

would you like to give it a try?

tommygod3 commented 5 years ago

Yeah I can give it a try, removing authomatic and consequently OpenID, and instead using oauthlib sounds good. I will develop these changes in cedadev/pyramid-phoenix so I can collaborate with @watucker

tommygod3 commented 4 years ago

@cehbrecht Unfortunately my last day on placement is tomorrow and I never had the time to look at doing this