search

bird-sanctuary / bluejay

:bird: Digital ESC firmware for controlling brushless motors in multirotors
GNU General Public License v3.0
312 stars 36 forks source link

Add functionality to support two char layouts. Add OA layout. #113 #114

Closed stylesuxx closed 1 year ago

stylesuxx commented 1 year ago

This is a suggestion for 2 character layouts.

We would be able to add new layouts with new numbers basically arbitrarily. I think this is better than going in alphabetical order since we can relate new layouts. For example, the new OA layout is based on the O layout - the relationship is pretty clear just by the name.

Technically this implementation would also allow us to use longer layout names - basically all the additional space that is blocked by spaces in the end could be used as layout name - I would not do it for now, but it would be an option.

I also asked over at BLHeli if there are any plans of adding more layouts, if that would be the case we would need make sure to have them properly synced up (https://github.com/bitdump/BLHeli/issues/698).

Open for suggestions here though - I am aware that it's not as elegant with the direct conversion from letter to ASCII code and such, but it seems like the most pragmatic solution.

stylesuxx commented 1 year ago

Test hardware should soon arrive, I will re-base and build a test hex asap.

stylesuxx commented 1 year ago

OA-hex.zip