search

bird-sanctuary / bluejay

:bird: Digital ESC firmware for controlling brushless motors in multirotors
GNU General Public License v3.0
312 stars 36 forks source link

Bi-Directional braking as a setting #137

Open stylesuxx opened 1 year ago

stylesuxx commented 1 year ago

Might be worth a shot to have this as a setting to improve motor direction reversal in 3D mode.

stylesuxx commented 1 year ago

This change seems to have brought great improvement on smaller quads: https://github.com/bird-sanctuary/bluejay/pull/136/commits/be25795e6a1e5437b70b86fcb0059505ca498e34 and basically eliminated all de-syncs on motor reversal.

Suggestion: We add this as a setting and allow the user to set this from 0x10 to 0x50. Or even better, show the corresponding eRPM.

@damosvil any thoughts on this?

damosvil commented 1 year ago

For now I would give it more time so people can provide feedback on the current change. I think that previous setting was tested on 14 pole motors, that are bigger and more powerful than the ones @egonl used in their builds during tests. The new setting should help for less powerful and 12 pole motors, in order to avoid stalls during startup, but I would like to wait until it is tested on bigger motors. If current settings are generic enough for a wider range of motors I would let it with no parameter, because the common user prefers that things just work out of the box. I would add the setting if we receive feedback from people that are uncomfortable with the current version though.