bird-sanctuary / bluejay

:bird: Digital ESC firmware for controlling brushless motors in multirotors
GNU General Public License v3.0
331 stars 36 forks source link

Update Docker Debian version #204

Closed hyp0dermik-code closed 2 months ago

hyp0dermik-code commented 3 months ago

See #203

Merge after #201 and #202

github-actions[bot] commented 3 months ago

Build artifacts:

hyp0dermik-code commented 3 months ago

This will likely break the current Github build environment and require the regeneration of the .wine folder

Docker image grows by 600MB from 1.2GB to 1.8GB

stylesuxx commented 3 months ago

Could you rebase this branch on latest develop please?

stylesuxx commented 3 months ago

@saidinesh5 will updating the Dockerfile trigger automatic re-generation builder package?

I would not like to fiddle with that if we can keep it in working condition, I remember that the initial setup was a bit of a PITA...

github-actions[bot] commented 3 months ago

Build artifacts:

saidinesh5 commented 3 months ago

We pushed the builder container manually to the repo iirc. But yeah let's avoid the docker file update ..

hyp0dermik-code commented 3 months ago

We pushed the builder container manually to the repo iirc. But yeah let's avoid the docker file update ..

So there would be technically no harm in updating the Docker file?

The disadvantage is it makes the environment harder to replicate, but the need to change the Dockerfile can be documented in the meantime

Shall we close it and document it for the meantime, and I'll leave the issue open for further investigation?

github-actions[bot] commented 3 months ago

Build artifacts:

stylesuxx commented 3 months ago

Yeah, if we pushed it manually, then there should not be a problem. For now let's leave this issue open.

I am not too familiar with the package part and how it is supposed to regenerate things. Since we do not have an action that is doing anything to it, I'd guess it won't update - unless there is some magic happening that I am unaware of.