search

bird-sanctuary / extended-dshot-telemetry

Extended DSHOT Telemetry (EDT) specification
GNU General Public License v3.0
12 stars 1 forks source link

Define period for max stress level #9

Open hyp0dermik-code opened 1 month ago

hyp0dermik-code commented 1 month ago

See https://github.com/bird-sanctuary/bluejay/pull/216

hyp0dermik-code commented 3 weeks ago

@AlkaMotors have you got any thoughts on this change to the specification? Are you currently using this field? Do you have any future plans for it that should be considered?

If I'm looking in the right place https://github.com/am32-firmware/AM32/blob/300f90ab2ef28346d44c9da52d7f1a2871d21870/Src/main.c#L1940 it would appear it is not currently implemented

@mbuzdalov FYI and any input too. See the linked Bluejay PR also

mbuzdalov commented 3 weeks ago

This indeed makes more sense to reset the maximum each time a frame is sent.

The initial version made some sense too as you could not miss a big stress event, because all subsequent readings would contain it too. However, on some of my machines some motors have a very difficult start, but then function nicely, in which case a high max stress in status was misleading.

From the Ardupilot side, this change should not result in any code change. We accumulate the maximum values for both [0..255] stress and [0..15] stress between log writes (which may happen not too often depending on how logging is configured), but once a log entry is written, the stored maxima are erased anyway.

I will look through what we say in documentation though, and maybe this needs to be slightly updated. Support for EDTv2 still did not reach a stable version anyway, only developer versions have it, so no problem at all.

hyp0dermik-code commented 3 weeks ago

@neoxic for your input too

EDIT: ESCape only uses EDTv1 and has no need for EDTv2 at this time, so has no preference

neoxic commented 6 days ago

EDIT: ESCape only uses EDTv1 and has no need for EDTv2 at this time, so has no preference

Sorry if it doesn't really belong here, but what I would really appreciate to see in EDT is the way to transmit external/motor temperature. Some ESCs have two temperature sensors (internal and external), and all standard sensored motors have built-in temperature sensors.