bird-team / brisbane-bird-atlas

Atlas of the Birds of Brisbane: Community bird atlas for Brisbane, Australia
https://brisbanebirds.com
GNU General Public License v3.0
3 stars 0 forks source link

eBirder names no longer appearing on Surveyor Sheets #141

Closed Louis-Backstrom closed 5 years ago

Louis-Backstrom commented 5 years ago

The latest batch of surveyor sheets (March eBird update, did them about a week ago but only just noticed) have no names attached to the observers in the top 5 table. At a guess, I suspect this is because eBird just overhauled the checklist page design and the name scrubber is having trouble:

image

I don't know enough about the script that finds the names to really have any idea how to fix this but if I can work it out I'll give it a shot. Otherwise I think we need @jeffreyhanson's expertise

jeffreyhanson commented 5 years ago

Hi - thank you very much for looking into this! Yeah, the new checklist webpage is probably causing this issue. If you wanted to try fixing this, the relevant code is line 27 in code/functions/find_observer_name. I'll try taking a proper look at this tonight to see what I can do.

Louis-Backstrom commented 5 years ago

yep, managed to get that far but couldn't work out what "dd strong" meant (which I suspect is what needs to be changed). Should hopefully be straightforward though.

jeffreyhanson commented 5 years ago

I've just pushed a patch which should fix this - could you please try remaking the surveyor sheets to see if this fixes it?

Louis-Backstrom commented 5 years ago

Remaking assets at the moment. Will update when I get home tonight.

Louis-Backstrom commented 5 years ago

No good, still NAs :(

jeffreyhanson commented 5 years ago

Sorry about that. It seems to be working on my computer - could you please double check if you pulled the latest version of the atlas to your computer before running the command to remake the sheets?

Louis-Backstrom commented 5 years ago

Hmm okay, I'll try and do a full refresh build later - I won't be home until later tonight so I'll start it all then.

Louis-Backstrom commented 5 years ago

image Have hit this error twice now on make assets - I think it's probably just a standard out of resources error but it happens at the same place each time, and I've allocated plenty of resources (8GB/5 cores) to Docker...

Louis-Backstrom commented 5 years ago

Fixed itself up. Not sure what the error was but it was fixed when I ran make pull_assets first before make assets - closing issue.