search

birdofpreyru / react-native-fs

File system access for React Native
https://dr.pogodin.studio/docs/react-native-file-system
Other
160 stars 12 forks source link

iOS: Add a privacy manifest? #32

Closed birdofpreyru closed 5 months ago

birdofpreyru commented 6 months ago

See: https://github.com/itinance/react-native-fs/issues/1232

birdofpreyru commented 6 months ago

Looking at this: https://github.com/zoontek/react-native-permissions/pull/861/files — I've missed to reference the manifest file in Podspec.

raphaelheinz commented 5 months ago

Hi @birdofpreyru, when generating a privacy report in XCode, following error is displayed.

privacypolicy

However, uploading to TestFlight works without any problems :) I think the issue is that 1e75477 does not contain key NSPrivacyCollectedDataTypes. We should add it, even if it is empty...

If you like I can also open a PR.

JOSEJ94 commented 5 months ago

Hi, thank you for all your effort on maintaining this package, you're truly heroes! Apologies for putting pressure on you all, but is this going to be released any time soon ? We're 2 days away from this becoming a blocker.

As a workaround for anyone reading this. Please add this patch to your projects. (It's the same change PR https://github.com/birdofpreyru/react-native-fs/pull/38 included)

diff --git a/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy b/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
index c6976be..1e4b47e 100644
--- a/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
+++ b/node_modules/@dr.pogodin/react-native-fs/ios/PrivacyInfo.xcprivacy
@@ -26,5 +26,7 @@
    <array/>
    <key>NSPrivacyTracking</key>
    <false/>
+   <key>NSPrivacyCollectedDataTypes</key>
+   <array/>
 </dict>
 </plist>
birdofpreyru commented 5 months ago

Ok @JOSEJ94 , I just released it as v2.24.6. I did not know it was any urgent, thus wasn't thinking to release before I find time to do the library upgrade for RN@0.74 (#39).

JOSEJ94 commented 5 months ago

Thank you so much! I'm not used to write in any repo, but in this case It was kind of urgent! You can get more information about this here. I have installed it and tested it by submitting a build into testflight and can confirm it's no longer giving warnings

birdofpreyru commented 5 months ago

Great, @JOSEJ94 I take your words as it is confirmed to work alright, and thus this issue can be closed now.