birdofpreyru / react-native-fs

File system access for React Native
https://dr.pogodin.studio/docs/react-native-file-system
Other
121 stars 8 forks source link

Fix bug in conversion of boolean values from RN to ObjC for downloadFile() #47

Closed stetbern closed 1 month ago

stetbern commented 1 month ago

Boolean values were not correctly converted from RN to ObjC for downloadFile(), so all values were always true.

The PR fixes the problem, the values specified by the user from RN are now also used in the native iOS part.

The background download mode is no longer started automatically, the “discretionary” flag is no longer automatically set to true.

The “cacheable” flag can now also be set to false by the user.

The explanation of “discretionary” in the readme has been clarified.