search

birkenfeld / ads-rs

Rust crate to access PLCs via the Beckhoff ADS protocol
https://crates.io/crates/ads
Apache License 2.0
45 stars 8 forks source link

Enable Github Actions #26

Closed keenanjohnson closed 3 months ago

keenanjohnson commented 3 months ago

hey @birkenfeld !

I just started using this project as an alternative to the official Beckhoff C++ lib and I love it!

I would really like to see this project succeed in the long term, so just poking around to see what I can do to help improve the stability / confidence.

I noticed that although there is a github actions workflow defined, it doesn't look like it is running. Get that up and running seems like an obvious first step to increase the quality / stability of the lib.

Is there any reason you haven't enabled the workflow and anything I can do to help there?

birkenfeld commented 3 months ago

Hi @keenanjohnson, thanks for the nice words!

I checked the workflow and it looked fine, but I updated it nevertheless and added a few bells and whistles :) In https://github.com/birkenfeld/ads-rs/pull/27 everything ran as expected.

I'll be happy for other suggestions, and of course, also for code PRs if you have something to submit :+1:

keenanjohnson commented 3 months ago

Excellent! Yes I see that it's running now. I guess that it had just been too long since a commit and Github stopped running the CI workflow?

I'm sure I'll be submitting a few things into the project. One other small suggestion I might make for Github is to turn on the "Discussions" feature if you want to give the community a place to ask questions rather than opening issues for all questions which I've seen be quite helpful for many projects.

Thanks!

birkenfeld commented 3 months ago

Discussions are enabled now!

keenanjohnson commented 3 months ago

Excellent! Thanks for the project!