birkenfeld / fddf

Fast data dupe finder
Apache License 2.0
109 stars 9 forks source link

A subtle bug #17

Closed manfredlotz closed 4 years ago

manfredlotz commented 6 years ago

I think there is a bug which just won't happen most of the times as the constellation is rare.

Assume two files systems mounted at

/mnt /mnt/sub

Run fddf /mnt Assume a file somefile exists with inode 4711 in /mnt. Assume further a file different_file exists with inode 4711 in /mnt/sub (i.e. in the second file system).

Those files would be regarded as hard links although this is not true.

This could be fixed by using both device id and inode when checking for hardlinks.