Closed lkolbly closed 2 years ago
Excellent, thanks! Unfortunately criterion also doesn't seem to support 1.41.1, can we make it somehow optional?
I think we can - I made it an optional dependency of serde-pickle
itself, so you can run cargo test
successfully on Rust 1.41.1. Then for cargo bench
, you'll still get an error on Rust 1.41.1, but only because it compiles out the benchmarks so there's nothing to run. I could put in a stub benchmark if we want.
Great, thanks!
Released in v1.1.1.
The criterion change isn't super important by itself, I was just using it because I like it for comparing changes (it will by default show a diff against the last run).
The
read_fixed_{2,4,8}_bytes
functions could be combined into a single function which uses const generics, but that would increase the MSRV so I opted not to.This change improves performance typically by double-digit percentages: