search

birkenfeld / serde-pickle

Rust (de)serialization for the Python pickle format.
Apache License 2.0
188 stars 28 forks source link

Use a more compatible serialization of bytes #6

Closed aidanhs closed 4 years ago

aidanhs commented 4 years ago

Based on the Python 3 serialization of byte strings in proto v2

aidanhs commented 4 years ago

I think the main thing I'd probably want to get in is the optimisation mentioned in the TODO, to use the memo for the two fixed strings - I'd probably put that in a major bump for safety because it influences how friendly the serializer is to other things serializing to the same pickle.

I'll probably get to in in the next couple of weeks if that works?

birkenfeld commented 4 years ago

Sounds good, I'll do the 1.0 then!

aidanhs commented 4 years ago

Just wanted to follow up on this - unfortunately I'm not using serde-pickle any more and so won't get round to adding that optimisation. Sorry!