birkir / homebridge-plugin-eufy-security

Eufy security homebridge plugin
Apache License 2.0
84 stars 18 forks source link

Receiving doorbell rings instead of motion alerts #5

Open Stichoza opened 3 years ago

Stichoza commented 3 years ago

I know it's too much to ask while repo is at its 4th commit, but I'll open this issue anyways.

Describe The Bug: The plugin registers motion alerts as doorbell rings. There is separated setting for motion alerts (which I have disabled in Home app for the doorbell) it

To Reproduce: Just walking past the doorbell and I get a notification "someone rang the doorbell".

Expected behavior: It should send "Someone is at your front door" kinda thing.

Screenshots:

Environment:

pashmore1971 commented 3 years ago

Yes, same issue here.

Stichoza commented 3 years ago

I think we can differentiate messages here: https://github.com/birkir/homebridge-plugin-eufy-security/blob/d331befaf6d2e89742a3fa94c20180c832d5e62f/src/platform.ts#L90

Example log:

Screen Shot 2020-12-02 at 22 52 16

Yet I couldn't find code 3100 in ParamType:

https://github.com/birkir/homebridge-plugin-eufy-security/blob/d331befaf6d2e89742a3fa94c20180c832d5e62f/src/eufy-types.ts#L29

birkir commented 3 years ago

I added the filter 👍

karesake commented 3 years ago

I added the filter 👍

Thanks. But now the HomePod isn't ringing anymore.

Stichoza commented 3 years ago

@birkir, I just saw the commit, the code I mentioned (3100) was for detected motions, not for doorbell rings. I'll debug the code and try to see which code is for button press.