Fixed PointOfInterest template and added openUrl

birkir / react-native-carplay

CarPlay with React Native

https://birkir.dev/react-native-carplay/

MIT License

625 stars 103 forks source link

Fixed PointOfInterest template and added openUrl #153

Open blanck opened 8 months ago

blanck commented 8 months ago

PointOfInterest template has been updated with: Parameters

primaryButton
secondaryButton
pinImage
selectedPinImage Actions
setPointsOfInterest
setPointOfInterestTitle Events
didChangeMapRegion

OpenURL method added Store and connect controller updated to include scene. Required to enable openUrl function to open other apps from an action button. Example to open a navigation app (Maps, Google Maps, Waze) and navigate to a POI. Example code: const url = 'maps://?q=London&ll=51.5074256%2C-0.1271814'; CarPlay.openUrl(url);

birkir commented 8 months ago

Very nice! Thank you for the contribution.

birkir commented 7 months ago

We are getting lockfile conflict because of "react-native": "" and "react": ""

Any reason for the change?

Once tests pass I'll merge!

ElangoPrince commented 7 months ago

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

birkir commented 7 months ago

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

It's not ready as far as I'm concerned.

ElangoPrince commented 7 months ago

@birkir Ohh, Okay. I'm waiting for this update. Its blocking me to proceed further. Can you give any possible way to use POI for now?

birkir commented 7 months ago

You can easily apply patches to any packages if you want. If using yarn 2+ you can use yarn patch Otherwise you can use patch-package

Feel free to use changes from this PR

saikiranm33 commented 3 months ago

@blanck still seeing the unsupported object issue