search

birkir / react-native-carplay

CarPlay with React Native
https://birkir.dev/react-native-carplay/
MIT License
625 stars 103 forks source link

Now playing image buttons are broken #171

Closed uzegonemad closed 4 weeks ago

uzegonemad commented 4 months ago

Describe the bug Image buttons on the now playing template were broken in 2f26991

If you see here you will notice that the CPNowPlayingImageButton is no longer using initWithImage.

I have a patch that fixes this and will create a PR.

To Reproduce Steps to reproduce the behavior:

  1. Add a now playing template with an image button
  2. No image displays on the button (a blank question mark symbol displays instead)

Expected behavior An image to display.

CarPlay (please complete the following information):

limadouglas commented 2 months ago

@uzegonemad It's worked for me: https://github.com/birkir/react-native-carplay/issues/6#issuecomment-799256543

The image must have dimensions of 80x80 pixels and be named <something>@3.png.

exemplo: arrow@3x

syedslegend786 commented 1 month ago

Describe the bug Image buttons on the now playing template were broken in 2f26991

If you see here you will notice that the CPNowPlayingImageButton is no longer using initWithImage.

I have a patch that fixes this and will create a PR.

To Reproduce Steps to reproduce the behavior:

  1. Add a now playing template with an image button
  2. No image displays on the button (a blank question mark symbol displays instead)

Expected behavior An image to display.

CarPlay (please complete the following information):

  • RNCarPlay version 2.4.0-beta.2

Hi, I am also working on react native app, to work it with android-auto. If you can share your project implementation repo, it will help alot, because i am facing issues with NowplayingTemplate

limadouglas commented 1 month ago

@syedslegend786 Sorry, I can't because it's a private project. If you are having issues, I recommend that you join the React Native Carplay Discord server and ask for help: https://discord.gg/b235pv6QHM.