search

bis-med-it / pysdmx

Your opinionated Python SDMX library
https://www.sdmx.io/tools/pysdmx/
Other
7 stars 0 forks source link

XML parsers for data reading #50

Open javihern98 opened 1 month ago

javihern98 commented 1 month ago

Depends on #46

javihern98 commented 2 weeks ago

@sosna @stratosn Please review the membership of @albertohernandez1995, seems he is not allowed to push

stratosn commented 2 weeks ago

@javihern98 the invitation to @albertohernandez1995 was sent last Monday, but it is still pending. @albertohernandez1995 can you check, please?

albertohernandez1995 commented 2 weeks ago

Hi @stratosn. I checked it and I have not recieved any invitation. Could you send it again, please? Thank you.

El vie, 28 jun 2024 14:43, Stratos Nikoloutsos @.***> escribió:

@javihern98 https://github.com/javihern98 the invitation to @albertohernandez1995 https://github.com/albertohernandez1995 was sent last Monday, but it is still pending. @albertohernandez1995 https://github.com/albertohernandez1995 can you check, please?

— Reply to this email directly, view it on GitHub https://github.com/bis-med-it/pysdmx/issues/50#issuecomment-2196823023, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFFJSX3X6NDGBES55LZQSPLZJVK5JAVCNFSM6AAAAABIBFKSBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWHAZDGMBSGM . You are receiving this because you were mentioned.Message ID: @.***>

stratosn commented 2 weeks ago

Hi @albertohernandez1995 can you check here: https://github.com/settings/organizations The invitation should be there. If not, we can send a new one.

javihern98 commented 1 week ago

Hi @stratosn all good now, thanks!

javihern98 commented 1 week ago

@sosna @stratosn Would you have somewhere a data file that references a Provision Agreement for testing?

<message:Structure structureID="AAA"
                   namespace="urn:dummy"
                   dimensionAtObservation="AllDimensions">
    <common:ProvisionAgrement>
        ....................................
    </common:ProvisionAgrement>
</message:Structure>
stratosn commented 1 week ago

Hi @javihern98, do you need an example on how to reference a Provision Agreement or the actual data file with the related Structures?

javihern98 commented 1 week ago

Probably the actual file with the related structures, to implement it properly

stratosn commented 1 week ago

Ok, then we need to prepare something from scratch, but if you already have a dataset that references a Dataflow, then the changes should not be a lot.

javihern98 commented 1 week ago

Yes, please use this file. This references a dataflow from a dataset.

stratosn commented 1 week ago

Sorry cannot see the file on GH. Maybe you could upload using the UI, or simply send it to me by email.

javihern98 commented 1 week ago

Sorry @stratosn , please find it here (changed externsion to TXT to upload it correctly):

BIS_DER_DATAFLOW.txt

stratosn commented 1 week ago

Thanks, @javihern98 This file can easily refer to the Provision Agreement, only by changing the header <message:Structure> content, ie:

        <message:Structure structureID="BIS_WEBSTATS_DER_DATAFLOW_1_0"
                           namespace="urn:sdmx:org.sdmx.infomodel.datastructure.Dataflow=BIS:WEBSTATS_DER_DATAFLOW(1.0):ObsLevelDim:TIME_PERIOD"
                           dimensionAtObservation="AllDimensions">
            <common:ProvisionAgrement>
                <Ref agencyID="BIS" id="WEBSTATS_DER_DATAFLOW_PRA" version="1.0"/>
            </common:ProvisionAgrement>
        </message:Structure>

Note that the 2.1 schemas include a typo (ProvisionAgrement instead of ProvisionAgreement)

Of course, this is the only change directly impacted by the referencing, but if you wanted to make it more meaningful, it might be useful to consider further Constraints. If you need something more on that, please let me know.