search

biscuit-auth / biscuit-go

Apache License 2.0
75 stars 22 forks source link

feat: upgrades to go@1.19, participle@v2.0.0 #118

Closed cludden closed 1 year ago

cludden commented 1 year ago

This fixes conflicts between this module and other modules with a dependency on github.com/alecthomas/participle/v2.

divarvel commented 1 year ago

Thanks! I've cleared the CI to run

cludden commented 1 year ago

Thanks @divarvel, looks like I forgot to update the go version in test.Dockerfile, updated and test locally 🙏

divarvel commented 1 year ago

the remaining error seems unrelated to your changes, i think it happens on every branch (i'm not familiar with the CI jobs though, so i'm not sure how to fix it)

cludden commented 1 year ago

Thanks for taking a look! Let me know if there's anything else I can do!

divarvel commented 1 year ago

if you rebase your branch on top of the latest main commit, CI should be green :+1:

(you might want to update the go version it the GHA config as well)

cludden commented 1 year ago

rebased and included the go version update to GHA config 👍

divarvel commented 1 year ago

Thanks!

FYI I'm planning on updating the test suite to add more thorough checks on the conformance suite, and then start working on biscuit V3 support.

Don't hesitate to reach out if you have feedback/ questions