biscuit-auth / biscuit-go

Apache License 2.0
75 stars 22 forks source link

Refresh test suite #120

Closed divarvel closed 1 year ago

divarvel commented 1 year ago

The goal of this PR is to make full use of the samples by generating tests thanks to the samples.json file

Please note:

divarvel commented 1 year ago

Just a high-level read-through as I'm trying to catch up 😄

Thanks! I'll be able to unskip the world comparisons on scoped facts in a follow-up PR now that we have https://github.com/biscuit-auth/biscuit-rust/pull/156

divarvel commented 1 year ago

alright, the test suite now uses all the information from the JSON file.

The samples containing v4 blocks are still skipped, as well as the 017 sample, which uncovered some bug / missing parts in the current implementation. They are handled in #121