biscuit-auth / biscuit-go

Apache License 2.0
75 stars 22 forks source link

Version 4 format features #146

Open yaronf opened 5 months ago

yaronf commented 5 months ago

This PR implements several v4 format features:

Along the way I solved several bugs and added some unit tests.

Since this is a very large PR, I suggest to review it commit by commit.

Also, since it still doesn't implement all of the v4 format, please merge it into a separate branch for now.

Lastly, just like #142, this implementation does not minimize the version number when serializing. I need your help in understanding the relevant code.

seh commented 3 weeks ago

Is this patch still viable for making it in? I don't see anyone having reviewed it yet.

divarvel commented 3 weeks ago

it has not been reviewed yet indeed.

based on the description, it still needs a bit of work on the block version selection before being merged. As for merging partial support of the v4 blocks, it could be ok, depending on the missing features, but that will required a thorough review