search

biscuit-auth / biscuit-java

Java implementation of the Biscuit authentication and authorization token
https://biscuitsec.org/
Apache License 2.0
28 stars 13 forks source link

2.0 #33

Closed Geal closed 2 years ago

KannarFr commented 2 years ago

\o/

KannarFr commented 2 years ago

Closed in favor of https://github.com/CleverCloud/biscuit-java/pull/35.

Geal commented 2 years ago

(reopening this since I can't push on the branch in #35) @Korbik did some awesome work in getting biscuit-java to 2.0! It's in good shape now and can be tested (let's wait a bit before publishing)

Keruspe commented 2 years ago

Switch from Either to Exceptions => :sob:

Korbik commented 2 years ago

Switch from Either to Exceptions => 😭

Trust me I tried to avoid it but without syntaxic sugar from Scala, Haskell or Rust. It was too painful to use. https://github.com/Korbik/biscuit-java/commit/4ffb88f616f56db2e2b10dbea1f5f64f6d24b0c2

https://github.com/Korbik/biscuit-java/blob/java_examples/src/test/java/com/clevercloud/biscuit/token/ExampleTest.java

KannarFr commented 2 years ago

I rebased master.

@Korbik you are still the author of the commits I don't know why GitHub doesn't show ur avatar on the commits as it's done for @Geal and me. If you know the reason, do not hesitate to tell me and I'll change it.

Can we consider the job is done for v2.0?

Keruspe commented 2 years ago

@KannarFr my blind guess is that cedric.corbiere[AT]*[DOT]com is not registered in @Korbik github account

Korbik commented 2 years ago

@KannarFr my blind guess is that cedric.corbiere[AT]*[DOT]com is not registered in @Korbik github account

Wrong email in the commit. I should have changed it.

Korbik commented 2 years ago

I rebased master.

@Korbik you are still the author of the commits I don't know why GitHub doesn't show ur avatar on the commits as it's done for @Geal and me. If you know the reason, do not hesitate to tell me and I'll change it.

Can we consider the job is done for v2.0?

The API won't move but I still needs to migrate to junit-5 and implements the tests based on samples.json.

I will rewrite my history to set the right email.

Korbik commented 2 years ago

Now we can enter in beta phase. And we will be able to release soon if we don't have too much bugs. All the current tests are okay: