Make default symbol table conform to the spec

biscuit-auth / biscuit-java

Java implementation of the Biscuit authentication and authorization token

https://biscuitsec.org/

Apache License 2.0

28 stars 13 forks source link

Make default symbol table conform to the spec #38

Closed divarvel closed 2 years ago

divarvel commented 2 years ago

See https://github.com/biscuit-auth/biscuit/issues/94

Korbik commented 2 years ago

We should add a test in the biscuit's specs samples.

divarvel commented 2 years ago

Yes, I'm waiting for consensus on where to go. Once we have it we can cover this case in the samples

KannarFr commented 2 years ago

It still needs some updates in the binary files. Waiting for symbols spec and I think @Geal will push binary tests files to spec accordingly. Then I'll bump them here.

divarvel commented 2 years ago

~I'll close this PR in favour of your work~

I’ll wash my eyes and get some coffee.

KannarFr commented 2 years ago

LGTM, test17 fails due to missing Add on String and test23 due to the authorization scope not being implemented.

@Korbik @Geal @divarvel can we merge this?