search

biscuit-auth / biscuit-java

Java implementation of the Biscuit authentication and authorization token
https://biscuitsec.org/
Apache License 2.0
31 stars 14 forks source link

samples verify block by block #88

Closed KannarFr closed 5 months ago

KannarFr commented 7 months ago

This is DRAFT.

Geal commented 7 months ago

BTW is there a good way in maven to capture stdout in tests, so that we only display it for tests that failed?

Geal commented 7 months ago

https://github.com/biscuit-auth/biscuit-java/pull/94 merges the parts of this PR that were already usable, leaving the samples block checks and the Parser.datalog method.

Right now I am not too convinced about the implementation of that method that does manual string manipulations. An implementation that follows the rest of the parser, using parser combinators, would fit better here and prevent errors. The Rust reference implementation can be used as inspiration here https://github.com/biscuit-auth/biscuit-rust/blob/main/biscuit-parser/src/parser.rs#L895-L970

Geal commented 5 months ago

closing this since it has been merged as part of https://github.com/biscuit-auth/biscuit-java/pull/102