biscuit-auth / biscuit-rust

Rust implementation of the Biscuit authorization token
https://www.biscuitsec.org
209 stars 29 forks source link

add a key argument to test cases #181

Closed Geal closed 1 year ago

Geal commented 1 year ago

this will help in the migration to the new version of ed25519-dalek and rand. Test cases use a RNG with a static seed, but generation changed

divarvel commented 1 year ago

wouldn't it be better to have the verification mode read the key from the samples file? That's what other implementations do, since they can't rely on rng consistency with rust, and read everything else from the samples file.

Geal commented 1 year ago

I can add it, but it would only work with the json output, not the markdown output

divarvel commented 1 year ago

Is the markdown output used by automated tooling? I have only used the JSON output in biscuit-haskell and biscuit-go.

Geal commented 1 year ago

Not used by automated tooling, but very useful when debugging the crypto algorithms, as I'm doing right now 😄

Geal commented 1 year ago

working from json requires a larger refactoring of the samples, so I'll do that as follow up, and merge this for now, as it will unblock the ed25519-dalek upgrade