search

biscuit-auth / biscuit-rust

Rust implementation of the Biscuit authorization token
https://www.biscuitsec.org
209 stars 29 forks source link

make sure that we actually need to run the datalog engine #197

Open Geal opened 11 months ago

Geal commented 11 months ago

the authorizer needs the datalog engine to have executed before performing certain tasks, but we might have already done it precedently, without having added facts or rules. This adds a boolean tracking if we need to run: if we added facts or rules, it is set to true, if we have just run the datalog engine, it is set to false

codspeed-hq[bot] commented 4 months ago

CodSpeed Performance Report

Merging #197 will not alter performance

Comparing geal/prevent-reruns (99b3824) with main (71f4350)

Summary

✅ 12 untouched benchmarks

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (71f4350) to head (99b3824).

Files Patch % Lines
biscuit-auth/src/token/authorizer.rs 79.16% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ======================================= Coverage 67.47% 67.48% ======================================= Files 25 25 Lines 5347 5370 +23 ======================================= + Hits 3608 3624 +16 - Misses 1739 1746 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.