biscuit-auth / biscuit-rust

Rust implementation of the Biscuit authorization token
https://www.biscuitsec.org
209 stars 29 forks source link

Expose PEM/DER decoder functions in KeyPair #204

Closed baranyildirim closed 8 months ago

baranyildirim commented 8 months ago

To make it easier to loader KeyPairs, expose PEM and DER loaders from the ed25519_dalek crate. PEM and DER are common formats for a key pair, so this should make loading a KeyPair easier.

divarvel commented 8 months ago

Thanks! idk how @Geal feels about it, but I think it should be feature-gated. Apart from that, LGTM

baranyildirim commented 8 months ago

Thanks! idk how @Geal feels about it, but I think it should be feature-gated. Apart from that, LGTM

Added a feature gate called "pem" to match the feature gate in the underlying crate.

Geal commented 8 months ago

good idea, thanks