biscuit-auth / biscuit-wasm

WebAssembly wrapper for Biscuit authorization tokens
Apache License 2.0
24 stars 10 forks source link

Prep for v0.4.0 #34

Closed divarvel closed 1 year ago

divarvel commented 1 year ago
ptondereau commented 1 year ago

If you are in the rush to publish this release, I can suggest this small nitpick: In snippets/definitions/tagged-template.d.ts you can replace, for example:

export function fact(strings: string[], ...values: any[]): Fact;

by

export function fact(strings: TemplateStringsArray, ...values: any[]): Fact;

TemplateStringsArray is just an interface on readonly string[] and extends ReadonlyArray<string>

divarvel commented 1 year ago

If you are in the rush to publish this release, I can suggest this small nitpick: In snippets/definitions/tagged-template.d.ts you can replace, for example:

export function fact(strings: string[], ...values: any[]): Fact;

by

export function fact(strings: TemplateStringsArray, ...values: any[]): Fact;

TemplateStringsArray is just an interface on readonly string[] and extends ReadonlyArray<string>

oh, TIL, thanks! i wondered if there was a way to explicitly mention the use case.

No rush at all, i'd be very glad to have an other pair of eyes on the API before releasing.