bisdn / basebox

A tiny OpenFlow controller for OF-DPA switches.
Mozilla Public License 2.0
45 stars 9 forks source link

nl_bridge: always set port stp state #399

Closed KanjiMonster closed 1 year ago

KanjiMonster commented 1 year ago

The kernel will set ports to disabled while the bridge interface is down to inhibit forwarding regardless wether STP is enabled for the bridge, and we should be doing the same.

So do not ignore port STP state changes when STP is disabled.

Fixes: ee54b7ae49d2 ("nl_bridge: implement tracking global and pervlan stp state; adds struct to track g/pv stp states; adds setting of stp state in the ASIC")

Description

see above

Motivation and Context

Bridges while down should not allow communication between ports at all.

How Has This Been Tested?

Pinging between hosts via switch, once with the bridge interface down, once up (e.g. vlan-bridge test).

Before pinging succeeds always regardless of admin state of bridge, after only if the bridge is up.