search

bisdn / bisdn-linux

Other
9 stars 1 forks source link

default.xml: replace extra manifests with groups #67

Closed KanjiMonster closed 1 year ago

KanjiMonster commented 1 year ago

Replace the external extra manifests files with additional projects in the default.xml, assigned to non-default groups.

To avoid the internal project being checked out by default, add it to the special group "notdefault", which prevents it from being added to the default "all" group.

This allows having all projects in one place. Repo requires all projects to have unique paths, so we cannot replace the open source one, but need to use it as an additional layer. Therefore check it out as meta-ofdpa-closed.

This requires additional changes to the internal meta-ofdpa repo to allow coexistence with the open one to avoid name collisions.

This way the repository can be initialized as normal via

repo init -b master -u ...

and for the internal development variant

repo init -b master -u ... -g all,ofdpa-gitlab

Note that you must include the all group, else you will only get the projects from the ofdpa-gitlab group.

Also since yocto does not support auto-detection of layers, you will then need to add the closed layer manually via

bitbake-layers add-layer <pathtolayer>

The advantage of this is that the generated release default.xml will then contain fixed revisions for all checked out projects, including the internal one when checked as well.

Signed-off-by: Jonas Gorski jonas.gorski@bisdn.de

jklare commented 1 year ago

Maybe the commit message could be more explicit about which groups we assign here and why. Judging from the docs i found (https://gerrit.googlesource.com/git-repo/+/master/docs/manifest-format.md), there are no 'non-default' groups as mentioned in the commit message, but there is however a 'notdefault' one, which has a very specific function:

If you place a project in the group “notdefault”, it will not be automatically downloaded by repo

I think it would be good to somehow relay this information in the commit message.

ideaship commented 1 year ago

There are no changes to README.md in the MR. Am I right to assume that for outside users, the build process stays exactly the same?

KanjiMonster commented 1 year ago

Updated and expanded the commit message and PR message (and answering your question).

ideaship commented 1 year ago

Updated and expanded the commit message and PR message (and answering your question).

Is bitbake-layer add really bitbake-layers add-layer?

KanjiMonster commented 1 year ago

Updated and expanded the commit message and PR message (and answering your question).

Is bitbake-layer add really bitbake-layers add-layer?

Yes. Wanted to replace it with the correct command, but forgot before pushing. Fixed, and marked as draft to avoid merging before the appropriate builder changes are merged.