search

bisguzar / twitter-scraper

Scrape the Twitter Frontend API without authentication.
MIT License
3.88k stars 600 forks source link

added-profileBanner-feature #126

Closed ozanbayram closed 4 years ago

ozanbayram commented 4 years ago

I added a new feature. it gets a profile banner photo. This is my first contributing I have done so far to open source projects.

bisguzar commented 4 years ago

Thanks for fix, but you still need to update documentation from readme.md. Looks like you only updated example code, I can merge it if you update documentation. Don't forget to add yourself as contributor btw ^^

ozanbayram commented 4 years ago

i don't understand what exactly should i update in readme.md

ozanbayram commented 4 years ago

I will add myself to contributors tomorrow.

bisguzar commented 4 years ago

To the table, 62-73. lines. I can add it by myself easily but you told its your first contribution. So its better if you do.

ozanbayram commented 4 years ago

The table is just about tweets with get_tweets(). But feature that I added is about profile with classProfile. If you still want me to add, I will add 'banner_photo' to table.¹

bisguzar commented 4 years ago

You are right, my bad. I don't know why we don't have a attributes table for Profile class. Maybe I should crate it, thanks again for your contribution^^