bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Update MyLinks.ascx to have the "active" Css Class. #192

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
THere's a hidden feature in Subtext I'd like to expose via *every* default 
skin. Here's an example of the MyLinks.ascx control in my skin. Notice the 
ActiveCssClass property of the NavigationLink control.

<%@ Control Language="c#" Inherits="Subtext.Web.UI.Controls.MyLinks" %>
<ul>
    <li class="pagehome">
        <span><st:NavigationLink Runat="server" 
NavigateUrl="~/Default.aspx" Text="Home" ID="HomeLink" 
ActiveCssClass="current" /></span>
    </li>
    <li class="pagearchives">
        <span><st:NavigationLink Runat="server" 
NavigateUrl="~/Archives.aspx" Text="Archives" ID="Archives" 
ActiveCssClass="current" /></span>
    </li>
    <li class="pagecontact">
        <span><st:NavigationLink Runat="server" 
NavigateUrl="~/Contact.aspx" Text="Contact" ID="ContactLink" 
ActiveCssClass="current" /></span>
    </li>
    <li class="pageresume">
        <span><a href="/Docs/PhillipHaack_Resume.html" title="My 
Resume">Resume</a></span>
    </li>
    <li class="pageprivacy">
        <span><st:NavigationLink Runat="server" 
NavigateUrl="/articles/PrivacyPolicy.aspx" Text="Privacy" 
ActiveCssClass="current" /></span>
    </li>
    <li class="pagejobs">
        <span></span>
    </li>
</ul>
<!-- Not Visible -->
<asp:HyperLink Runat="server" NavigateUrl="~/Rss.aspx" ID="XMLLink" 
Visible="False" title="RSS Feed" />
<asp:HyperLink Runat="server" NavigateUrl="~/Rss.aspx" Text="Syndication" 
ID="Syndication" title="Syndication" Visible="False" />
<asp:HyperLink Runat="server" Text="Admin" ID="Admin" title="Admin" 
Visible="False" />

Original issue reported on code.google.com by haac...@gmail.com on 11 Mar 2010 at 5:49

GoogleCodeExporter commented 9 years ago

Original comment by haac...@gmail.com on 9 May 2010 at 6:13

GoogleCodeExporter commented 9 years ago
Moving to the next release. Nice to have, but not urgent.

Original comment by haac...@gmail.com on 10 May 2010 at 3:59

GoogleCodeExporter commented 9 years ago
I could do this one. I'm just wondering if the value of the ActiveCssClass 
property should be "current" or "active". In your sample it's current. Within 
the MyLinks.ascx of the Nature skin it's "active".

Original comment by codemu...@googlemail.com on 28 Dec 2010 at 4:28

GoogleCodeExporter commented 9 years ago
Technically, it doesn't matter as long as it matches the value in the skin's 
CSS. For consistency sake though, let's use "active" since as you pointed out, 
the Nature skin uses it. If you supply a patch, we'd be grateful. :)

Original comment by haac...@gmail.com on 29 Dec 2010 at 6:22

GoogleCodeExporter commented 9 years ago
The changes to the MyLinks.ascx files are done. As most skins don't have a rule 
for the active state of a navigation link, I'm currently editing the css files 
in order to add such a rule.
Patch should be there by the end of this week

Original comment by codemu...@googlemail.com on 30 Dec 2010 at 1:00

GoogleCodeExporter commented 9 years ago
done

Original comment by codemu...@googlemail.com on 31 Dec 2010 at 5:08

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r4171. Thanks for the patch!

Original comment by haac...@gmail.com on 31 Dec 2010 at 5:48

GoogleCodeExporter commented 9 years ago
You're welcome. But it seems that two images that I've created didn't make it 
into my patch file (even though I've selected them). Sorry for that!

Could you please add them to the
\Skins\Semagogy\Images directory?

Original comment by codemu...@googlemail.com on 31 Dec 2010 at 6:27

Attachments:

GoogleCodeExporter commented 9 years ago
done!

Original comment by haac...@gmail.com on 31 Dec 2010 at 6:43