bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Links in generated rss feeds contains + (plus) signs #199

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
all spaces in links in body of rss feeds are replaced with plus signs.
It has negative side because links like http://bla-bla/tag/bla+bla/
default.aspx and http://bla-bla/tag/bla bla/default.aspx are different for 
IIS 7 and it generates 404 error if a user tries to use a link with 
pluses. 

There is a workaround for IIS 7 but it decrease security (see explanation 
here http://blogs.iis.net/thomad/archive/2007/12/17/iis7-rejecting-urls-
containing.aspx)

For example, in Tim Heuer's blog: if we open rss feed we will find a link 
to the Trusted Application tag (http://timheuer.com/blog/tags/trusted
+application/default.aspx)

the same tag in the tag cloud will look like http://timheuer.com/blog/Tags/
trusted%20application/default.aspx

So, it would be nice to generate links in rss feeds without pluses

Original issue reported on code.google.com by Max.Paul...@gmail.com on 2 Apr 2010 at 11:45

GoogleCodeExporter commented 9 years ago
I think we should look into fixing this one for the next release.

Original comment by haac...@gmail.com on 5 Apr 2010 at 3:20

GoogleCodeExporter commented 9 years ago
Thank you very much

Original comment by Max.Paul...@gmail.com on 5 Apr 2010 at 7:44

GoogleCodeExporter commented 9 years ago
There seems to be a minor issue with the TagLinks plug-in for the FCKEditor 
which
causes the first space in a tag to be replaced with a plus sign. I think that 
the
author's intent was for all spaces to be replaced with plus signs. Yet from this
issue it seems that it's better to leave spaces as they are, or even possibly
HTML-encode them upon insertion.

Anyways, the attached patch removed the space replacement from the TagLinks 
plugin. I
could change it to HTML encode the tags if that is the preferred behavior.

Original comment by mohammad.b.abdulfatah on 13 Apr 2010 at 9:10

Attachments:

GoogleCodeExporter commented 9 years ago
I could not reproduce the original issue. I will apply this patch though. 
Thanks 
Mohammad.

Original comment by haac...@gmail.com on 10 May 2010 at 3:57