Undo mark as spam/approve/delete doesn't work

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Go to the feedback page in the admin
2. Mark a comment as spam
3. Without leaving the page click on undo

What is the expected output? What do you see instead?
I expect to see the comment that I first flagged and then undo-ed still in the 
approved comment section, while I see it in the marked as spam.

Original issue reported on code.google.com by simone.chiaretta on 9 Jun 2010 at 10:04

[GoogleCodeExporter]

I'm not an expert in the undoable thing, but shouldn't the undo link restore 
the previous status, instead of setting the same again?
Furthermore, I guess that when you mark something that was "potential spam" as 
"approved" it should be marked as "false positive", not just as approved.

Original comment by simone.chiaretta on 9 Jun 2010 at 10:23

[GoogleCodeExporter]

there are actually three bugs:

 * the undo doesn't work
 * then when from spam goes to approved it becomes just approved and not as false positive (code directly sets the flag instead of using the Approve/ConfirmSpam/Delete methods)
 * finally false positives are still reported as being spam in the list

All this seems like a big work, but not sure if we need to fix this for 2.5.1 
or if it can skip to a later release.

Original comment by simone.chiaretta on 9 Jun 2010 at 12:22

[GoogleCodeExporter]

I guess the big question is:
do we want to keep on tracking the "history" of a feedback (using the flag) or 
can we just go to a simple status of the feedback?

Original comment by simone.chiaretta on 9 Jun 2010 at 12:31

[GoogleCodeExporter]

Fixed in r4190

Original comment by haac...@gmail.com on 16 May 2011 at 5:29

• Changed state: Fixed
• Added labels: Milestone-Release2.6