search

bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Image resizing in galleries does not work #229

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In SubText 2.5.0.3 images uploaded to a gallery are no longer resized at all (i 
mean the r_xxx.xxx file).
The r_xxx.xxx is the same resolution of the o_xxx.xxx.

Original issue reported on code.google.com by mbord...@gmail.com on 20 Jun 2010 at 1:17

GoogleCodeExporter commented 8 years ago

Original comment by haac...@gmail.com on 22 Jun 2010 at 8:35

GoogleCodeExporter commented 8 years ago 
Do you recall what the expected behavior is supposed to be? What should the 
r_xxx.xxx be resized to?

Original comment by haac...@gmail.com on 25 Jun 2010 at 7:43

GoogleCodeExporter commented 8 years ago 
I meant that if I upload an image (image.jpg) to a Subtext 2.0 gallery I'll 
find 3 files:
t_image.jpg (the thumbnail)
r_image.jpg (the resized version of image.jpg that mantains the geometry with a 
the height and width max to 640pixels)
o_image.jpg (the original renamed version of image.jpg)

In Subtext 2.5 the r_image.jpg is not resized to 640 any more.
Is this a bug or do I have to config something somewhere to have again that 
feature?

Thanks
Michele

Original comment by mbord...@gmail.com on 25 Jun 2010 at 9:23

GoogleCodeExporter commented 8 years ago 
Definitely a bug. Thanks.

Original comment by haac...@gmail.com on 25 Jun 2010 at 8:31

GoogleCodeExporter commented 8 years ago 
I was not able to reproduce this. We only resize images that are *larger* than 
640. Try uploading a large image to see if it resizes.

Images smaller than 640 are not resized.

Original comment by haac...@gmail.com on 25 Jun 2010 at 8:39

GoogleCodeExporter commented 8 years ago 
I've uploaded 2 images and it seems that the only rule is about the max height 
(480) but I did not find limit for the width.
You can find the originals here:
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/o_image.jpg 
(1352x879)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/o_image2.jpg 
(1514x868)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/o_image3.jpg 
(1227x475)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/o_image4.jpg 
(1227x536)

and the resized version here:
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/r_image.jpg 
(738x480)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/r_image2.jpg 
(837x480)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/r_image3.jpg 
(640x248)
http://bordoni.dyndns.org/blog/images/bordoni_dyndns_org/blog/100/r_image4.jpg
(640x280)

What is the current resizing rule?
max height = 480
max width = ??
Sincerely I cannot understand which is the logic of the current resizing module.

Subtext 2.0 resized everything to 640 in width and then if the height was still 
bigger than 640 it resized again the picture in order to have an height max of 
640.

Can I change those value

Original comment by mbord...@gmail.com on 25 Jun 2010 at 10:43

GoogleCodeExporter commented 8 years ago 
Ah! I see the problem. The logic is *supposed* to be that we resize the image 
so that it retains its aspect ratio *and* it fits within a 640 x 480 rectangle. 
However, I found a bug in our code. I'll fix the bug and make it configurable 
via web.config.

Original comment by haac...@gmail.com on 26 Jun 2010 at 5:56

GoogleCodeExporter commented 8 years ago 
Fixed in r4080. Added config settings in r4081

Original comment by haac...@gmail.com on 26 Jun 2010 at 6:27