search

bishop335 / subtext

Automatically exported from code.google.com/p/subtext
0 stars 0 forks source link

Plain HTML editor is requested #245

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I do (and I know other people also) my blog posts in plain HTML, just because I 
more get used to.. and fill more control, instead of using WYSIWYG editors.

It would be nice if Subtext users have ability to decide what kind of editor do 
they want, WYSIWYG or PLAIN one.

Options -> Preferences:

Use plain HTML editor [Yes/No] - No is default.

If used selects Yes, in Post Edit page he sees just a multiline texteditor 
control, not CKEditor.

Original issue reported on code.google.com by alexande...@gmail.com on 28 Jul 2010 at 1:19

GoogleCodeExporter commented 9 years ago 
If this enchanment is approved, I could pick it up :)

Original comment by alexande...@gmail.com on 29 Jul 2010 at 10:23

GoogleCodeExporter commented 9 years ago 
Sure! Make it happen. :)

Original comment by haac...@gmail.com on 29 Jul 2010 at 3:17

GoogleCodeExporter commented 9 years ago 
Roger that :)

Original comment by alexande...@gmail.com on 30 Jul 2010 at 1:53

GoogleCodeExporter commented 9 years ago 
Submitting a patch. Could any one pick up for review, verification?

Implementation details:
1. Add new preference on Preference page - "Use plain HTML editor"
2. Exented Preference class with new preference, made it public to work under 
tests.
3. Changed RichTextEditor to create a provider based on user option.
4. Created unit tests for all my changes.

Simple development test - done

Patch in attachment :)

Original comment by alexande...@gmail.com on 31 Jul 2010 at 11:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Current test resport:

1507 passed, 2 failed, 4 skipped (see 'Task List'), took 53,21 seconds (MbUnit 
2.4.2).

Original comment by alexande...@gmail.com on 31 Jul 2010 at 12:00

GoogleCodeExporter commented 9 years ago 
I'm without a "real" connection till next Sunday and the mobile dongle I have 
is pretty slow (well, it shouldn't be, but it is), I'll apply the patch as soon 
as I come back.

Original comment by simone.chiaretta on 1 Aug 2010 at 8:47

GoogleCodeExporter commented 9 years ago

Original comment by simone.chiaretta on 1 Aug 2010 at 11:20

GoogleCodeExporter commented 9 years ago 
Applied the patch in r4099.
Alex, can you please have a look at it, see if everything is implemented 
correctly?
Also, can you have a look at the possibility to remove the httpsimulator from 
the test you submitted?
Thx

Original comment by simone.chiaretta on 1 Aug 2010 at 12:30

GoogleCodeExporter commented 9 years ago 
Simone, thanks for appying this!

It seems to be everething is OK! :)

Regaring HttpSimulator, I've used for tests that are depending on 
HttpContext.Current.. without SimulateRequest() call context will be null, so 
exception will be thrown. It is required, could not be removed.

Original comment by alexande...@gmail.com on 1 Aug 2010 at 2:15

GoogleCodeExporter commented 9 years ago 
Good... so I mark it a verified

Original comment by simone.chiaretta on 1 Aug 2010 at 2:23